Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] tms_account: Analytic configuration #153

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[IMP] tms_account: Analytic configuration #153

wants to merge 1 commit into from

Conversation

max3903
Copy link
Member

@max3903 max3903 commented Nov 3, 2024 •
edited
Loading

@max3903 max3903 added this to the 17.0 milestone Nov 3, 2024
@OCA-git-bot
Copy link
Contributor

Hi @EdgarRetes, @santiagordz,
some modules you are maintaining are being modified, check this out!

@max3903
Copy link
Member Author

max3903 commented Nov 6, 2024

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@max3903 The rebase process failed, because command git push --force ursais tmp-pr-153:17.0-imp_tms_account failed with output:

remote: Permission to ursais/stock-logistics-transport.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ursais/stock-logistics-transport/': The requested URL returned error: 403

@max3903 max3903 force-pushed the 17.0-imp_tms_account branch from 6456066 to 4b05d42 Compare November 6, 2024 15:36
@rousseldenis
Copy link
Contributor

Same here. Not to bother but to ensure commit history is clean on main branches and respect OCA conventions. Thanks

@max3903 max3903 mentioned this pull request Nov 6, 2024
Merged
@max3903
Copy link
Member Author

max3903 commented Nov 6, 2024

@EdgarRetes Can you review this one as well please?

@EdgarRetes
Copy link

@EdgarRetes Can you review this one as well please?

It works fine

@max3903 max3903 changed the title [IMP] tms_account [IMP] tms_account: Analytic configuration Nov 6, 2024
@max3903 max3903 requested a review from rousseldenis November 6, 2024 16:51
gbrito
gbrito approved these changes Nov 12, 2024
View reviewed changes
Copy link

@gbrito gbrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't saw anything that could break, just notice the @api.model on all create and write methods. Shouldn't we change the create method to model_create_multi and remove the one from the write method?

Probably this will impact the rest of the modules that depend/ inherit this one?

@max3903
Copy link
Member Author

max3903 commented Nov 12, 2024

@gbrito Thanks for the review. There is not much modules depending on it yet.

CC: @EdgarRetes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbrito gbrito gbrito approved these changes

@rousseldenis rousseldenis Awaiting requested review from rousseldenis

Assignees
No one assigned
Labels
enhancement needs review
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@max3903 @OCA-git-bot @rousseldenis @EdgarRetes @gbrito